Base fixes and test harness

PortfolioJournal/ViewModels/SourceDetailViewModel.swift

@@ -12,6 +12,7 @@ class SourceDetailViewModel: ObservableObject {
     @Published var predictions: [Prediction] = []
     @Published var predictionResult: PredictionResult?
     @Published var transactions: [Transaction] = []
+    @Published var isDeleted = false
 
     @Published var isLoading = false
     @Published var showingAddSnapshot = false
@@ -37,6 +38,7 @@ class SourceDetailViewModel: ObservableObject {
     private var isRefreshing = false
     private var refreshQueued = false
     private var refreshTask: Task<Void, Never>?
+    private let sourceName: String
 
     // MARK: - Initialization
 
@@ -50,6 +52,7 @@ class SourceDetailViewModel: ObservableObject {
         iapService: IAPService
     ) {
         self.source = source
+        self.sourceName = source.name
         self.snapshotRepository = snapshotRepository ?? SnapshotRepository()
         self.sourceRepository = sourceRepository ?? InvestmentSourceRepository()
         self.transactionRepository = transactionRepository ?? TransactionRepository()
@@ -103,6 +106,11 @@ class SourceDetailViewModel: ObservableObject {
 
         refreshTask = Task { [weak self] in
             guard let self else { return }
+            guard !self.isDeleted, !self.source.isDeleted, self.source.managedObjectContext != nil else {
+                self.isDeleted = true
+                self.isRefreshing = false
+                return
+            }
             while self.refreshQueued && !Task.isCancelled {
                 self.refreshQueued = false
 
@@ -232,6 +240,23 @@ class SourceDetailViewModel: ObservableObject {
         showingEditSource = false
     }
 
+    func deleteSource() {
+        guard !isDeleted else { return }
+        // Mark deleted first so the view can dismiss before any further access.
+        isDeleted = true
+        snapshots = []
+        chartData = []
+        predictionResult = nil
+        // Cancel any pending notifications for this source
+        NotificationService.shared.cancelReminder(for: source)
+
+        // Log analytics before deletion
+        FirebaseService.shared.logSourceDeleted(categoryName: source.category?.name ?? "Uncategorized")
+
+        // Delete the source using the existing repository
+        sourceRepository.deleteSource(source)
+    }
+
     // MARK: - Predictions
 
     func showPredictions() {
@@ -256,6 +281,13 @@ class SourceDetailViewModel: ObservableObject {
         currentValue.currencyString
     }
 
+    var safeSourceName: String {
+        if source.isDeleted || source.managedObjectContext == nil {
+            return sourceName
+        }
+        return source.name
+    }
+
     var totalReturn: Decimal {
         metrics.absoluteReturn
     }